fix(kobo): Split Library controller and align names with tests

ragusa87 · Dec 7, 2024 · b3d2086 · b3d2086
1 parent d749a9a
commit b3d2086
Show file tree

Hide file tree

Showing 12 changed files with 22 additions and 15 deletions.
diff --git a/...troller/Kobo/Api/V1/LibraryController.php → ...Kobo/Api/V1/Library/LibraryController.php b/...troller/Kobo/Api/V1/LibraryController.php → ...Kobo/Api/V1/Library/LibraryController.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace App\Controller\Kobo\Api\V1;
+namespace App\Controller\Kobo\Api\V1\Library;
 
 use App\Controller\Kobo\AbstractKoboController;
 use App\Entity\Book;

diff --git a/src/Controller/Kobo/Api/V1/Library/MetadataController.php b/src/Controller/Kobo/Api/V1/Library/MetadataController.php
diff --git a/src/Controller/Kobo/Api/V1/Library/StateController.php b/src/Controller/Kobo/Api/V1/Library/StateController.php
diff --git a/...ller/Kobo/KoboAnalyticsControllerTest.php → ...r/Kobo/Api/V1/AnalyticsControllerTest.php b/...ller/Kobo/KoboAnalyticsControllerTest.php → ...r/Kobo/Api/V1/AnalyticsControllerTest.php
@@ -1,11 +1,12 @@
 <?php
 
-namespace App\Tests\Controller\Kobo;
+namespace App\Tests\Controller\Kobo\Api\V1;
 
 use App\DataFixtures\KoboFixture;
 use App\Entity\KoboDevice;
+use App\Tests\Controller\Kobo\AbstractKoboControllerTest;
 
-class KoboAnalyticsControllerTest extends AbstractKoboControllerTest
+class AnalyticsControllerTest extends AbstractKoboControllerTest
 {
     public const SERIAL_NUMBER = 'N9413679432456';
     public const DEVICE_ID = '2a92bba197b1e0574a3f7d29cb2b05b399ab0d197e6b1aa230bfb75a920b14e7c';

diff --git a/...oller/Kobo/KoboDownloadControllerTest.php → ...er/Kobo/Api/V1/DownloadControllerTest.php b/...oller/Kobo/KoboDownloadControllerTest.php → ...er/Kobo/Api/V1/DownloadControllerTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace App\Tests\Controller\Kobo;
+namespace App\Tests\Controller\Kobo\Api\V1;
 
 use App\DataFixtures\BookFixture;
 use App\DataFixtures\KoboFixture;
@@ -9,8 +9,9 @@
 use App\Kobo\DownloadHelper;
 use App\Kobo\Response\MetadataResponseService;
 use App\Repository\BookRepository;
+use App\Tests\Controller\Kobo\AbstractKoboControllerTest;
 
-class KoboDownloadControllerTest extends AbstractKoboControllerTest
+class DownloadControllerTest extends AbstractKoboControllerTest
 {
     public function testDownload(): void
     {

diff --git a/...obo/KoboInitializationControllerTest.json → .../Api/V1/InitializationControllerTest.json b/...obo/KoboInitializationControllerTest.json → .../Api/V1/InitializationControllerTest.json
diff --git a/...Kobo/KoboInitializationControllerTest.php → ...o/Api/V1/InitializationControllerTest.php b/...Kobo/KoboInitializationControllerTest.php → ...o/Api/V1/InitializationControllerTest.php
@@ -1,12 +1,13 @@
 <?php
 
-namespace App\Tests\Controller\Kobo;
+namespace App\Tests\Controller\Kobo\Api\V1;
 
 use App\DataFixtures\KoboFixture;
 use App\Tests\Contraints\JSONContainKeys;
+use App\Tests\Controller\Kobo\AbstractKoboControllerTest;
 use Symfony\Component\BrowserKit\Response;
 
-class KoboInitializationControllerTest extends AbstractKoboControllerTest
+class InitializationControllerTest extends AbstractKoboControllerTest
 {
     /**
      * @throws \JsonException
@@ -62,7 +63,7 @@ public function testInitialization(): void
         self::assertResponseIsSuccessful();
         self::assertResponseHasHeader('kobo-api-token');
 
-        $content = file_get_contents(__DIR__.'/KoboInitializationControllerTest.json');
+        $content = file_get_contents(__DIR__ . '/KoboInitializationControllerTest.json');
         if ($content === false) {
             self::fail('Unable to read test data');
         }

diff --git a/...Controller/Kobo/KoboTagControllerTest.php → ...ler/Kobo/Api/V1/KoboTagControllerTest.php b/...Controller/Kobo/KoboTagControllerTest.php → ...ler/Kobo/Api/V1/KoboTagControllerTest.php
@@ -1,10 +1,11 @@
 <?php
 
-namespace App\Tests\Controller\Kobo;
+namespace App\Tests\Controller\Kobo\Api\V1;
 
 use App\DataFixtures\KoboFixture;
 use App\DataFixtures\ShelfFixture;
 use App\Entity\Shelf;
+use App\Tests\Controller\Kobo\AbstractKoboControllerTest;
 
 class KoboTagControllerTest extends AbstractKoboControllerTest
 {

diff --git a/tests/Controller/Kobo/Api/V1/Library/MetadataControllerTest.php b/tests/Controller/Kobo/Api/V1/Library/MetadataControllerTest.php
diff --git a/...ntroller/Kobo/KoboStateControllerTest.php → ...bo/Api/V1/Library/StateControllerTest.php b/...ntroller/Kobo/KoboStateControllerTest.php → ...bo/Api/V1/Library/StateControllerTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace App\Tests\Controller\Kobo;
+namespace App\Tests\Controller\Kobo\Api\V1\Library;
 
 use App\DataFixtures\BookFixture;
 use App\DataFixtures\KoboFixture;
@@ -13,12 +13,13 @@
 use App\Kobo\Request\ReadingStateStatistics;
 use App\Kobo\Request\ReadingStateStatusInfo;
 use App\Kobo\Response\StateResponse;
+use App\Tests\Controller\Kobo\AbstractKoboControllerTest;
 use Symfony\Component\Serializer\SerializerInterface;
 
 /**
  * @phpstan-type ReadingStateCriteria array{'book':int, 'readPages': int|null, 'finished': boolean}
  */
-class KoboStateControllerTest extends AbstractKoboControllerTest
+class StateControllerTest extends AbstractKoboControllerTest
 {
     public function testOpen(): void
     {

diff --git a/...ontroller/Kobo/KoboSyncControllerTest.php → ...obo/Api/V1/Library/SyncControllerTest.php b/...ontroller/Kobo/KoboSyncControllerTest.php → ...obo/Api/V1/Library/SyncControllerTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace App\Tests\Controller\Kobo;
+namespace App\Tests\Controller\Kobo\Api\V1\Library;
 
 use App\DataFixtures\BookFixture;
 use App\DataFixtures\KoboFixture;
@@ -11,9 +11,10 @@
 use App\Service\KoboSyncTokenExtractor;
 use App\Tests\Contraints\AssertHasDownloadWithFormat;
 use App\Tests\Contraints\JSONIsValidSyncResponse;
+use App\Tests\Controller\Kobo\AbstractKoboControllerTest;
 use App\Tests\TestClock;
 
-class KoboSyncControllerTest extends AbstractKoboControllerTest
+class SyncControllerTest extends AbstractKoboControllerTest
 {
     protected function setUp(): void
     {

diff --git a/...dServiceCheckForChangesControllerTest.php → ...ler/Kobo/Api/V3/ContentControllerTest.php b/...dServiceCheckForChangesControllerTest.php → ...ler/Kobo/Api/V3/ContentControllerTest.php
@@ -1,10 +1,11 @@
 <?php
 
-namespace App\Tests\Controller\Kobo;
+namespace App\Tests\Controller\Kobo\Api\V3;
 
+use App\Tests\Controller\Kobo\AbstractKoboControllerTest;
 use Symfony\Component\HttpFoundation\Response;
 
-class ReadServiceCheckForChangesControllerTest extends AbstractKoboControllerTest
+class ContentControllerTest extends AbstractKoboControllerTest
 {
     public function testCheckForChangesPost(): void
     {