Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Clojure binary name handling #1221

Merged
merged 9 commits into from
Nov 19, 2024
Merged

Update Clojure binary name handling #1221

merged 9 commits into from
Nov 19, 2024

Conversation

FarazPatankar
Copy link
Contributor

This PR updates how we look for Clojure binaries to set the start command. Upon merging:

  • We will support .jar files with our without -standalone in the name
  • We will ignore .jar files with -SNAPSHOT.jar in the name

I have also added an example using clojure-luminus which prompted this PR.

@FarazPatankar FarazPatankar added the release/patch Author patch release label Nov 13, 2024
@coffee-cup coffee-cup mentioned this pull request Nov 15, 2024
Closed
@FarazPatankar FarazPatankar merged commit fe69a74 into main Nov 19, 2024
101 checks passed
@FarazPatankar FarazPatankar deleted the fp/clojure-binary-name branch November 19, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coffee-cup coffee-cup coffee-cup approved these changes

Assignees
No one assigned
Labels
release/patch Author patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FarazPatankar @coffee-cup