feat: Metamask SDK integration with the metamask wallet connector #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EdouardBougon is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
omridan159
suggested changes
Jul 4, 2024
| getUri: shouldUseWalletConnect ? getUri : undefined, | ||
| }, | ||
| qrCode: shouldUseWalletConnect | ||
| mobile: isMobile() |
There was a problem hiding this comment.
I think that it would be better to separate the inline functions into: getMobile, getQrCode, and getExtension standalone functions.
It will improve readability.
The expected end result::
mobile: getMobile(),
qrCode: getQrCode(),
extension: getExtension()
omridan159
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Metamask SDK integration with the metamask wallet connector