OrderBook Subgraph testing CI #36
Conversation
2023 30 09 subgraph cli
remove submodule recursive
There was a problem hiding this comment.
other than the specific comments, high level concerns
- The PR is far too large, it seems like this easily could have been split into smaller PRs, as it stands we have 68 thousand LOC to review in a single pass
- the rust code is generally undocumented and untested
- commented out code and typos makes the PR appear unfinished to me, probably a symptom of it being so large that you couldn't even check it properly yourself @NanezX
| @@ -0,0 +1,76 @@ | |||
| use colored::*; | |||
There was a problem hiding this comment.
don't have undifferentiated util modules
|
|
||
| let full_cmd = format!("{} {}", main_cmd, args.join(" ")); | ||
|
|
||
| println!("{} {}\n", "Running:".green(), full_cmd.blue()); |
There was a problem hiding this comment.
use tracing not println
| stdout_handle.join().expect("Failed to join stdout thread"); | ||
|
|
||
| if status.success() { | ||
| println!("✅ {} {}\n", full_cmd.blue(), "completed".green()); |
There was a problem hiding this comment.
use standard tracing and standard log levels, emojis and colours could cause issues for logging/monitoring tools
| version: '3' | ||
| services: | ||
| evm_node: | ||
| image: vishalkale151071/hardhat-node |
There was a problem hiding this comment.
private docker, use org
| - postgres | ||
| extra_hosts: | ||
| - host.docker.internal:host-gateway | ||
| environment: |
There was a problem hiding this comment.
hardcoded environment?
| let end_point = "http://localhost:8020/"; | ||
| let subgraph_name = "test/test"; | ||
|
|
||
| let data = MapBuilder::new() |
There was a problem hiding this comment.
why are we working with unstructured string interpolation? does serde_yaml not work?
| std::env::current_dir().unwrap().display(), | ||
| root_dir | ||
| )) | ||
| .args(&["-c", "npx graph codegen && npx graph build"]) |
|
|
||
| pub struct Query; | ||
|
|
||
| impl Query { |
|
|
||
| pub struct SyncStatus; | ||
|
|
||
| pub async fn wait() -> anyhow::Result<bool> { |
| @@ -0,0 +1,1252 @@ | |||
| { | |||
There was a problem hiding this comment.
why are generated files being committed to the repo?
|
closing as this should be smaller PRs |
No description provided.