Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasm bindings for order quoting #957

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add wasm bindings for order quoting #957

wants to merge 9 commits into from
+324 −18

Conversation

findolor
Copy link
Collaborator

@findolor findolor commented Oct 23, 2024 •
edited
Loading

Closes #956

Caution

Do not merge before #955

Motivation

See issue: #956

Solution

  • Add the wasm binding for single order quoting

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@findolor findolor self-assigned this Oct 23, 2024
@findolor findolor linked an issue Oct 23, 2024 that may be closed by this pull request
Add wasm bindings for quote logic for JS usage #956
Open
@findolor findolor changed the base branch from 2024-10-22-order-quotes-logic to main October 25, 2024 04:55
@findolor findolor mentioned this pull request Oct 29, 2024
Open
@findolor findolor linked an issue Oct 29, 2024 that may be closed by this pull request
webapp shows wrong pairs in the quote table rainlanguage/rain.webapp#114
Open
@findolor findolor removed a link to an issue Oct 29, 2024
webapp shows wrong pairs in the quote table rainlanguage/rain.webapp#114
Open
@rouzwelt rouzwelt added js/wasm Update wasm/js new feature Added a new feature labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh Awaiting requested review from hardyjosh

At least 1 approving review is required to merge this pull request.

Assignees

@findolor findolor

@rouzwelt rouzwelt

Labels
js/wasm Update wasm/js new feature Added a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add wasm bindings for quote logic for JS usage
2 participants
@findolor @rouzwelt