use rbenv+ruby-build instead of rvm #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-202312-try-rbenv-and-ruby-build
branch
3 times, most recently
from
75846f9
to
6018b4d
Compare
10 tasks
so changes are easier to see
flavorjones
force-pushed
the
flavorjones-202312-try-rbenv-and-ruby-build
branch
from
6018b4d
to
79e3bd7
Compare
|
@larskanis are you OK with this change? can you let me know if you have concerns or want to get on a call to discuss it? |
|
Sorry @flavorjones for the delay! In general I'm fine with the change. The sendfile patches were necessary for VirtualBox. I guess this is still the case, but VirtualBox emulation for docker is not very common these days. So we can remove them. In any case: Great work! |
larskanis
approved these changes
Dec 30, 2023
- user `rvm` no longer exists, replaced by `rubyuser` - `rvm` has been replaced by `rbenv` and `ruby-build` - no longer applying the sendfile patches to Ruby - no longer updating gems belonging to the bootstrap rubies
flavorjones
force-pushed
the
flavorjones-202312-try-rbenv-and-ruby-build
branch
from
79e3bd7
to
9e321ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #75 I found that RVM has issues on Alpine, specifically rvm/rvm#5255
Now, while we could probably use another musl-based image (and not Alpine specifically, since the RVM problem is really related to Alpine's use of busybox), I will point out that ruby-build appears to be more actively maintained than rvm, is simpler, and is a bit easier to work with. So I think this is a good change regardless (pending green tests).
Changes:
rvmno longer exists, replaced byrubyuserrvmhas been replaced byrbenvandruby-buildAlso in this PR, I've updated the predefined user and group lists to be the superset of all our images.