Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix title overlapping y-axis; reposition carousel buttons #452

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented Jul 26, 2024

Related Item(s)

#446 #447

Changes

  • Repositioned the carousel buttons so that they no longer overlap elements below the carousel
  • Resized chart title text on smaller screen sizes so the title shouldn't overlap the chart data
  • Removed a bunch of x-margin so the charts take up more width on smaller screens
  • Added a y-overflow to charts so the legend doesn't get cut off

Testing

Steps:

  1. Open the demo page on a small screen.
  2. Ensure chart titles are not overlapping charts
  3. Ensure the charts are taking up a reasonable width within the panel
  4. Ensure that the carousel buttons are not overlapping the text below

This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/fix-446/#/en/00000000-0000-0000-0000-000000000000

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@dnlnashed dnlnashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

@yileifeng yileifeng merged commit 9741c16 into ramp4-pcar4:main Aug 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants