Remove all References to the internal Directories #217
Conversation
luthermonson
force-pushed
the
drop-internal
branch
3 times, most recently
from
d480c94
to
c85e742
Compare
luthermonson
force-pushed
the
drop-internal
branch
2 times, most recently
from
d34d070
to
907dcf5
Compare
luthermonson
changed the title
luthermonson
force-pushed
the
drop-internal
branch
from
907dcf5
to
0159c9f
Compare
|
Hey @luthermonson thanks for the PR. Can you please rebase it (to v1beta1 API) and we can then give it a review? |
|
@furkatgofurov7 ya ill get that updated |
luthermonson
force-pushed
the
drop-internal
branch
2 times, most recently
from
bf4c728
to
a5d0f92
Compare
|
@furkatgofurov7 ready to run workflows |
Signed-off-by: Luther Monson <lmonson@akamai.com>
luthermonson
force-pushed
the
drop-internal
branch
from
a5d0f92
to
c044e75
Compare
|
@furkatgofurov7 updated again and ready for workflows to be ran |
There was a problem hiding this comment.
Overall looks good to me except a small nit below, @richardcase do you have any comments?
| @@ -9,7 +9,8 @@ | |||
| "go.mod", | |||
| "go.sum", | |||
| "api", | |||
| "internal", | |||
| "controllers", | |||
There was a problem hiding this comment.
Have we tried running Tilt with these changes? I assume it was already broken before this PR (I can only see a single pkg folder in the repo which is in the root), but would be good to fix it with the same change since we are touching it anyway
There was a problem hiding this comment.
i have not, i just made sure things compiled. not sure i even know what change you'd like me to make? change controllers to bootstrap/controllers ?
There was a problem hiding this comment.
@luthermonson sorry for not making it clear, I was referring to "pkg" which does not exist inside of neither https://github.com/luthermonson/cluster-api-provider-rke2/tree/drop-internal/bootstrap and https://github.com/luthermonson/cluster-api-provider-rke2/tree/drop-internal/controlplane.
It is not a blocker for this PR and can be done (if it makes sense!) in a follow-up as well.
|
@luthermonson would you have time to rebase and resolve the open comment in #217 (comment) ? |
|
@luthermonson gentle ping to know if you are still interested picking this up back. |
|
Feel free to re-open if needed, closing for now. |
kind/feature
What this PR does / why we need it:
I'd like to move everything in an
internaldirectory out so they can properly be included bygoimportsin other projects.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: