Add working vSphere template #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
requested review from
salasberryfin,
Danil-Grigorev and
furkatgofurov7
Danil-Grigorev
previously approved these changes
Aug 2, 2024
furkatgofurov7
previously approved these changes
Aug 2, 2024
alexander-demicev
dismissed stale reviews from furkatgofurov7 and Danil-Grigorev
via
974d7c4
alexander-demicev
force-pushed
the
vspheretemplate
branch
from
f64ca48
to
974d7c4
Compare
furkatgofurov7
approved these changes
Aug 5, 2024
|
e2e tests are failing, but that is unrelated (e2e failures on main as well) and changes of this PR can't be tested even they were green. This could be merged as is IMO. |
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev
force-pushed
the
vspheretemplate
branch
from
974d7c4
to
c90d451
Compare
furkatgofurov7
approved these changes
Aug 13, 2024
Danil-Grigorev
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds some fixes to make vSphere template work and merges all manifests in one template. Adding ClusterClass will be addressed later once we verify ClusterClasses work well in CAPRKE2.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #328
Special notes for your reviewer:
Checklist: