Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 docs: add pre-release actions to release guide #373

Conversation

salasberryfin
Copy link
Contributor

What this PR does / why we need it:

Add a post-release actions section to release guide.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@salasberryfin salasberryfin added the kind/documentation Improvements or additions to documentation label Jul 22, 2024
@salasberryfin salasberryfin changed the title docs: add post-release actions to release guide 📖 docs: add post-release actions to release guide Jul 22, 2024
docs/release.md Outdated Show resolved Hide resolved
@salasberryfin salasberryfin force-pushed the add-new-post-release-action-to-release-docs branch from b7fca9a to a969bc7 Compare July 23, 2024 09:02
@salasberryfin salasberryfin changed the title 📖 docs: add post-release actions to release guide 📖 docs: add pre-release actions to release guide Jul 23, 2024
docs/release.md Outdated Show resolved Hide resolved
@salasberryfin salasberryfin force-pushed the add-new-post-release-action-to-release-docs branch from a969bc7 to 905bac2 Compare July 30, 2024 14:00
@salasberryfin
Copy link
Contributor Author

My proposal is to have it documented for now and think about a potential automation in parallel. I updated the docs to reflect that E2E must be updated, as suggested by @furkatgofurov7

@salasberryfin salasberryfin changed the title 📖 docs: add pre-release actions to release guide [WIP] 📖 docs: add pre-release actions to release guide Jul 30, 2024
@salasberryfin salasberryfin marked this pull request as draft July 30, 2024 15:06
@salasberryfin
Copy link
Contributor Author

Thanks @furkatgofurov7 for suggesting we follow a similar release procedure to the one in upstream CAPI https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/release/release-tasks.md#prepare-main-branch-for-development-of-the-new-release. I'll update the docs and align the actions with this workflow.

@salasberryfin salasberryfin force-pushed the add-new-post-release-action-to-release-docs branch 4 times, most recently from 490392e to 597bd2a Compare August 7, 2024 08:23
@salasberryfin salasberryfin marked this pull request as ready for review August 7, 2024 08:23
@salasberryfin salasberryfin changed the title [WIP] 📖 docs: add pre-release actions to release guide 📖 docs: add pre-release actions to release guide Aug 7, 2024
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salasberryfin let's fix some small notes and re-run e2e tests on this one, once you are back 😉

docs/release.md Outdated Show resolved Hide resolved
@furkatgofurov7
Copy link
Contributor

@salasberryfin would you have time to update this PR soon?

@salasberryfin
Copy link
Contributor Author

Thanks for the reminder @furkatgofurov7. I forgot that this was still open.

furkatgofurov7
furkatgofurov7 previously approved these changes Aug 27, 2024
docs/release.md Outdated Show resolved Hide resolved
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salasberryfin salasberryfin merged commit a8256cc into rancher:main Aug 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants