-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Influence kernel parameters at install time #1773
Comments
I wonder if we can't reuse already the grub extra boot params envs instead of generating the grub.cfg. I've a mixed feeling about generating grub configs, at that point I feel we could drift away and show discrepancies between node, besides adding non-obvious code paths. |
Having a post-install hook seems also something that is already doable by using the |
This sounds really invasive and hard to maintain in the long run - do we need custom partition labels for state, persistency, and all? It feels reimplementing tools to generate grub configs. So.. gotta ask: what's the motivation behind this? If it comes to add boot parameters after install that's easily doable already by writing the grub env files, this can be easily instrumented from the agent too. |
It's mostly about any quirks your hardware/driver combination has and you need to work around by passing kernel parameters (for ISO boot and for disk boot) |
Right, but is this card about generating grub.cfg during install? That's a big design change as it starts to add dynamic config generation on runtime. For such options on the livecd is not needed, neither after install. I'm just concerned about dynamic configuration generation as it propagates down to other paths, e.g. when resetting a system |
The motivation is to decouple as much as possible the OS image contents from the installation details such as partition layout and its labels and also give the opportunity to set the kernel parameters, stuff like So I think it would be nice at install time to be capable to set partition labels and My idea is that the OS Image sets the bootloader configuration but there is an expectation between the given configuration and elemental-cli to define some values so there is no need to hardcode default literals. |
One more use case: rancher/cluster-api-provider-rke2#291 |
Elemental client
elemental install
command should have some way to easily influence the kernel parameters within the bootloader.Ideas:
This will allow us to set all labels at install time and remove any partition or filesystem label literal from
elemental-toolkit
repository.The text was updated successfully, but these errors were encountered: