Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the BindPath for /oem #1935

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Feb 6, 2024

Without this, the registration breaks (initramfs stages put in /oem are not read and executed).

Edit: also, /oem should be unmounted because of the Conflicts declaration in the oem-generator...

@frelon frelon requested a review from a team as a code owner February 6, 2024 13:20
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frelon frelon enabled auto-merge (squash) February 6, 2024 13:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af89ac6) 72.38% compared to head (1274e8b) 72.38%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1935   +/-   ##
=======================================
  Coverage   72.38%   72.38%           
=======================================
  Files          72       72           
  Lines        7934     7934           
=======================================
  Hits         5743     5743           
  Misses       1720     1720           
  Partials      471      471           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon disabled auto-merge February 6, 2024 14:02
@frelon frelon merged commit a5439f6 into rancher:main Feb 6, 2024
8 of 14 checks passed
@frelon frelon deleted the add-back-oem-bind branch February 6, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants