Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow toolkit #1946

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Workflow toolkit #1946

merged 4 commits into from
Feb 13, 2024

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Feb 9, 2024

Part of #1928

@frelon frelon requested a review from a team as a code owner February 9, 2024 09:32
@frelon frelon force-pushed the workflow-toolkit branch 2 times, most recently from aa0aeb2 to e42cb0b Compare February 9, 2024 13:41
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7dd5487) 72.04% compared to head (0428194) 72.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1946   +/-   ##
=======================================
  Coverage   72.04%   72.04%           
=======================================
  Files          72       72           
  Lines        8019     8019           
=======================================
  Hits         5777     5777           
  Misses       1779     1779           
  Partials      463      463           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frelon frelon force-pushed the workflow-toolkit branch 4 times, most recently from 5b15ccc to e62f5ba Compare February 13, 2024 09:44
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Build and push toolkit and os flavor before build-iso and build-disk.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
If a package is not built as a result of a tag, it should be cleaned up
after the tests are done.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon merged commit 595e5e7 into rancher:main Feb 13, 2024
4 checks passed
@frelon frelon deleted the workflow-toolkit branch February 13, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants