Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved upgrade test #1960

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Improved upgrade test #1960

merged 5 commits into from
Feb 16, 2024

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Feb 15, 2024

The upgrade test will now prepare a VM with an older (v1.1.4) version and then run the upgrade in podman to upgrade to the current PR container.

This will make sure we can upgrade from v1.1.4 to current and also that the correct version of the upgrade command is tested (the new one, not the old installed one).

Fixes #1928

@frelon frelon added kind/enhancement New feature or request area/upgrade labels Feb 15, 2024
@frelon frelon requested a review from a team as a code owner February 15, 2024 09:14
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc53c13) 72.04% compared to head (3998242) 72.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1960   +/-   ##
=======================================
  Coverage   72.04%   72.04%           
=======================================
  Files          72       72           
  Lines        8019     8019           
=======================================
  Hits         5777     5777           
  Misses       1779     1779           
  Partials      463      463           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This commit uses podman to run the latest version of the elemental-cli
to run the update command.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon force-pushed the new-upgrade-test branch 2 times, most recently from 6e388da to e7d6926 Compare February 15, 2024 14:07
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon
Copy link
Contributor Author

frelon commented Feb 15, 2024

Got a green upgrade run at https://github.com/rancher/elemental-toolkit/actions/runs/7917180349/job/21613080610?pr=1960 going back to pull_request_target event.

Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit lost with these changes... Shouldn't it be a new test, so we test both directions:

  1. from current head downgrade to a names tag/version
  2. from a named/tag version upgrade to current head

1 is what we already had, we are missing 2.

I guess this also apply to the recovery tests which in fact is just an upgrade test executed from recovery system.

@frelon
Copy link
Contributor Author

frelon commented Feb 15, 2024

I am a bit lost with these changes... Shouldn't it be a new test, so we test both directions:

  1. from current head downgrade to a names tag/version

  2. from a named/tag version upgrade to current head

1 is what we already had, we are missing 2.

I guess this also apply to the recovery tests which in fact is just an upgrade test executed from recovery system.

I can add back the old upgrade test and call it downgrade instead, then we get both tests named correctly 👍

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 👍

@frelon frelon merged commit 81015ee into main Feb 16, 2024
17 of 18 checks passed
@frelon frelon deleted the new-upgrade-test branch February 16, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/upgrade kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an upgrade test from an old installation to current PR
3 participants