-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump elemental-toolkit to v2 #1969
Conversation
6fa96e2
to
df28c1f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1969 +/- ##
=======================================
Coverage 72.53% 72.53%
=======================================
Files 76 76
Lines 8909 8909
=======================================
Hits 6462 6462
Misses 1913 1913
Partials 534 534 ☔ View full report in Codecov by Sentry. |
ad6fe12
to
edf8bbe
Compare
v1 "github.com/rancher/elemental-toolkit/pkg/types/v1" | ||
"github.com/rancher/elemental-toolkit/v2/pkg/constants" | ||
eleError "github.com/rancher/elemental-toolkit/v2/pkg/error" | ||
"github.com/rancher/elemental-toolkit/v2/pkg/types" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frelon if I understood what you meant you were imagining something like that right? So no v1 or v2, only types which somehow also reflects we are not supporting both on the same code base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, otherwise we could consider keeping the pkg/types/v1
directory and only making changes in v2
, but it feels like overkill to me 👍
f6171e8
to
c71a5c8
Compare
Signed-off-by: David Cassany <dcassany@suse.com>
This commit leaves the code with a single set of types and in refers to it as the types packge instead of v1 or v2. For the time being we do not foresee managing more than one single major version of type within the same code. Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Fixes #1927