Add cloud-init paths of the new root in 'after-*' hooks #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcassany
force-pushed
the
set_workdir_to_output
branch
4 times, most recently
from
9621cdd
to
2132cf5
Compare
davidcassany
changed the title
davidcassany
force-pushed
the
set_workdir_to_output
branch
from
2132cf5
to
d1e51eb
Compare
davidcassany
commented
Sep 24, 2024
davidcassany
force-pushed
the
set_workdir_to_output
branch
2 times, most recently
from
f109eb1
to
b9f6dea
Compare
This commit enables to run the non chrooted 'after-*' hooks included in the newly deployed image root. This specially applies to the install, reset, upgrade and build-disk commands. Moreover, 'after-disk' command now includes static reference paths to the new root and working directory, so that those can be used within the hooks regardless of the choosen output directory. Signed-off-by: David Cassany <dcassany@suse.com>
This commit introduces an arm-firmware feature adding the required after-* hooks to ensure the RPi firmware is copied to the EFI partition. It could be, eventually, extended to support other boards and it does not harm systems which are not including RPi firmware. Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
force-pushed
the
set_workdir_to_output
branch
from
b9f6dea
to
8f8d96b
Compare
davidcassany
added a commit
to davidcassany/elemental-toolkit
that referenced
this pull request
Oct 1, 2024
* Add cloud-init paths of the new root in 'after-*' hooks This commit enables to run the non chrooted 'after-*' hooks included in the newly deployed image root. This specially applies to the install, reset, upgrade and build-disk commands. Moreover, 'after-disk' command now includes static reference paths to the new root and working directory, so that those can be used within the hooks regardless of the choosen output directory. * Include arm-firwmare feature This commit introduces an arm-firmware feature adding the required after-* hooks to ensure the RPi firmware is copied to the EFI partition. It could be, eventually, extended to support other boards and it does not harm systems which are not including RPi firmware. * Allow features to be passed as arguments Signed-off-by: David Cassany <dcassany@suse.com> (cherry picked from commit 30a64d7)
davidcassany
added a commit
that referenced
this pull request
Oct 2, 2024
* Add cloud-init paths of the new root in 'after-*' hooks This commit enables to run the non chrooted 'after-*' hooks included in the newly deployed image root. This specially applies to the install, reset, upgrade and build-disk commands. Moreover, 'after-disk' command now includes static reference paths to the new root and working directory, so that those can be used within the hooks regardless of the choosen output directory. * Include arm-firwmare feature This commit introduces an arm-firmware feature adding the required after-* hooks to ensure the RPi firmware is copied to the EFI partition. It could be, eventually, extended to support other boards and it does not harm systems which are not including RPi firmware. * Allow features to be passed as arguments Signed-off-by: David Cassany <dcassany@suse.com> (cherry picked from commit 30a64d7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables to run the non chrooted 'after-*' hooks included in the newly deployed image root. This specially applies to the install, reset, upgrade and build-disk commands.
Moreover, 'after-disk' command now includes static reference paths to the new root and working directory, so that those can be used within the hooks regardless of the chosen output directory.
Part of rancher/elemental#1516