Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: machine default type matches rancher #1382

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix: machine default type matches rancher #1382

merged 2 commits into from
Aug 2, 2024

Conversation

matttrach
Copy link
Collaborator

addresses #1314

@matttrach
fix: machine default type matches rancher
f4c94a7 
Signed-off-by: matttrach <matt.trachier@suse.com>
@matttrach matttrach self-assigned this Aug 2, 2024
@matttrach matttrach requested a review from jiaqiluo August 2, 2024 20:29
@matttrach
fix: use template
e3d56f6 
Signed-off-by: matttrach <matt.trachier@suse.com>
jiaqiluo
jiaqiluo approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@jiaqiluo jiaqiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For the record, template is the default value that Rancher UI (dashboard) sets when creating a nodeTemplate.

https://github.com/rancher/dashboard/blob/08f11a5d813e216467b418961e12ec6ac6954e8c/shell/machine-config/vmwarevsphere.vue#L245

Screenshot 2024-08-02 at 1 57 34 PM

@matttrach
Copy link
Collaborator Author

thank you!

@matttrach matttrach merged commit a41ef9c into rancher:master Aug 2, 2024
1 check passed
@matttrach matttrach deleted the mc-default branch August 2, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaqiluo jiaqiluo jiaqiluo approved these changes

Assignees

@matttrach matttrach

Labels
None yet
Projects
None yet
Milestone
September Release 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@matttrach @jiaqiluo