update the azurerm version along with the resource variables #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweanan
changed the title
Nepomuceno
reviewed
Jan 20, 2023
modules/lb/main.tf
Outdated
| @@ -52,7 +52,7 @@ resource "azurerm_lb_backend_address_pool" "bepool" { | |||
| resource "azurerm_lb_probe" "this" { | |||
| name = "${var.name}-lb-cp-probe" | |||
| loadbalancer_id = azurerm_lb.this.id | |||
| resource_group_name = data.azurerm_resource_group.rg.name | |||
| # resource_group_name = data.azurerm_resource_group.rg.name | |||
There was a problem hiding this comment.
Do not leave in commented out code. If it should be removed just delete it.
There was a problem hiding this comment.
Thanks @Nepomuceno cleaned up the code
|
LGTM |
|
@Andrew-RF @joshrwolf Can you please merge this PR? |
|
We will evaluate this shortly. Thanks for your contribution.
On Tue, Feb 7, 2023 at 10:16 PM sweanan ***@***.***> wrote:
@Andrew-RF <https://github.com/Andrew-RF> @joshrwolf
<https://github.com/joshrwolf> Can you please merge this PR?
—
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUSQM265OLIJBPLOJCBPSLWWLCTTANCNFSM6AAAAAAUAQTZFQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Brandon
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the all the errors in the below issue :
cc: @robcamer @Nepomuceno