Various Fixes #340
Open
Various Fixes #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnomolos
commented
Jul 30, 2014
pnomolos
commented
- Fixes issue where XML character would be passed unencoded into attribute values, causing breakage
- You can pass a SimpleTypedList to be merged now (useful if you want to merge an entire row)
- Converted everything to Minitest
- Fixes issue where XML character would be passed unencoded into attribute values, causing breakage
- You can pass a SimpleTypedList to be merged now (useful if you want to merge an entire row)
- Also has the addition of Axlsx.to_emu_units
- Fix issue with it not being properly escaped
- @zoom_scale_normal, @zoom_scale_page_layout_view, @zoom_scale_sheet_layout_view all need to be set. A default of 0 is incorrect according to the Open XML SDK 2.5 Validator. - Due to the way serialized_attributes works, @name won't be set by default. This should probably be fixed by having serialized_attributes use method-based accessors rather than instance vars.
- Fix specs for SheetView now that defaults are different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.