Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly export 5-8 formats #664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Explicitly export 5-8 formats #664

wants to merge 1 commit into from

Conversation

jbosse
Copy link

@jbosse jbosse commented Feb 21, 2023

Excel sheets that use formats 5-8 export the formatCodes for 5-8 because 5-8 are not standard values. Even though Excel can read a file without the formatCodes for cells using this numFmtId values other libraries may arise an exception when detecting format ids without an accompanying code.

This PR explicitly adds them to all files. I would have preferred to only include them if they were used but I punted since always including styles for 100 and 101 seem to have been included without issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant