Merge pull request #19800 from zeroSteiner/fix/dns/caching-incompatib…

…le-answers Carry on if the record can't be cached
rapid7 · Jan 15, 2025 · 9c98804 · 9c98804
2 parents 6a4844b + e425bba
commit 9c98804
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/rex/proto/dns/cached_resolver.rb b/lib/rex/proto/dns/cached_resolver.rb
@@ -62,7 +62,11 @@ def send(argument, type = Dnsruby::Types::A, cls = Dnsruby::Classes::IN)
         resolved = super(resolve, type)
         req.instance_variable_set(:@answer, (req.answer + resolved.answer).uniq)
         resolved.answer.each do |ans|
-          self.cache.cache_record(ans)
+          begin
+            self.cache.cache_record(ans)
+          rescue StandardError => e
+            elog('Failed to cache the DNS answer', error: e)
+          end
         end
       end
       # Finalize answers in response