Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visibility to productinterface #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Jade-GG
Copy link
Collaborator

@Jade-GG Jade-GG commented Oct 22, 2024

I forgot that this is not standard magento, so this is actually necessary for rapidez/core#563

@royduin
Copy link
Member

royduin commented Oct 23, 2024

Don't forget the readme 😇

@royduin
Copy link
Member

royduin commented Nov 1, 2024

Do we still need this?

@Jade-GG
Copy link
Collaborator Author

Jade-GG commented Nov 1, 2024

The parent PR is closed, but it could still be useful for compadre so that, if you do want this in your query, you have the ability to use it without having to make your own magento plugin? I don't really know exactly what the scope of compadre is supposed to be---whether it's only for standard rapidez things or also for stuff that may be useful but isn't standard rapidez.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants