Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance tips to cudf.pandas FAQ. #16693

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 29, 2024

Description

This PR adds a section with performance tips to the cudf.pandas FAQ.

I based this section on some common user questions about performance, to make it clearer that cudf.pandas is designed for optimal performance with large data sizes and provide some alternatives for common needs where cudf or cudf.pandas aren't the best fit. See these links for examples:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice added doc Documentation non-breaking Non-breaking change labels Aug 29, 2024
@bdice bdice self-assigned this Aug 29, 2024
@bdice
Copy link
Contributor Author

bdice commented Aug 29, 2024

@KyleFromNVIDIA This is my first docs-only PR since we merged #16642. I am seeing an error:

Run tj-actions/changed-files@v45
changed-files
  Using local .git directory
  Running on a push event...
  Repository is shallow, fetching more history...
  Error: Not Found - https://docs.github.com/rest/git/refs#get-a-reference

@Matt711
Copy link
Contributor

Matt711 commented Aug 30, 2024

@KyleFromNVIDIA This is my first docs-only PR since we merged #16642. I am seeing an error:

Run tj-actions/changed-files@v45
changed-files
  Using local .git directory
  Running on a push event...
  Repository is shallow, fetching more history...
  Error: Not Found - https://docs.github.com/rest/git/refs#get-a-reference

I saw this error yesterday, updating the branch fixed it.

@vyasr
Copy link
Contributor

vyasr commented Sep 3, 2024

@KyleFromNVIDIA This is my first docs-only PR since we merged #16642. I am seeing an error:

Run tj-actions/changed-files@v45
changed-files
  Using local .git directory
  Running on a push event...
  Repository is shallow, fetching more history...
  Error: Not Found - https://docs.github.com/rest/git/refs#get-a-reference

I saw this error yesterday, updating the branch fixed it.

This was fixed in #16709

@bdice
Copy link
Contributor Author

bdice commented Sep 5, 2024

I'm struggling here. I can't reproduce the error in docs builds locally:

/__w/cudf/cudf/docs/cudf/source/cudf_pandas/faq.md:33: WARNING: 'myst' cross-reference target not found: 'does-cudf-pandas-work-with-third-party-libraries'

@bdice
Copy link
Contributor Author

bdice commented Sep 5, 2024

I got the docs figured out. All looks good. I'll merge this now.

@bdice
Copy link
Contributor Author

bdice commented Sep 5, 2024

/merge

@rapids-bot rapids-bot bot merged commit 0e86f62 into rapidsai:branch-24.10 Sep 5, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants