Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some unnecessary libcudf nightly builds #16714

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

jameslamb
Copy link
Member

Description

Follow-up to #16650 and #15483.

libcudf wheels are identical (same content, same filename) across Python versions, but due to an oversight in the PRs linked above, we're currently building nightlies of them once per Python version supported by RAPIDS 😭

You can see this on recent runs of the build workflow:

image

(build link)

This PR fixes that by applying the same matrix filter to libcudf nightly build jobs as is currently applied to PR jobs:

wheel-build-libcudf:
needs: checks
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-24.10
with:
matrix_filter: group_by([.ARCH, (.CUDA_VER|split(".")|map(tonumber)|.[0])]) | map(max_by(.PY_VER|split(".")|map(tonumber)))

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 30, 2024
@jameslamb jameslamb requested a review from a team as a code owner August 30, 2024 22:05
@bdice
Copy link
Contributor

bdice commented Aug 31, 2024

/merge

@rapids-bot rapids-bot bot merged commit 4ad4b23 into rapidsai:branch-24.10 Aug 31, 2024
86 checks passed
@jameslamb jameslamb deleted the fewer-libcudf-builds branch September 3, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants