Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Schema.Builder does not propagate precision value to Builder instance #17214

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix Schema.Builder does not propagate precision value to Builder instance #17214

merged 1 commit into from
Oct 31, 2024

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Oct 30, 2024

When calling Schema.Builder.build(), the value topLevelPrecision should be passed into the constructor of the Schema class. However, it was forgotten.

@ttnghia
Fix schema build
d61da82 
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia ttnghia added bug Something isn't working 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS labels Oct 30, 2024
@ttnghia ttnghia self-assigned this Oct 30, 2024
@ttnghia ttnghia requested a review from a team as a code owner October 30, 2024 22:10
@ttnghia ttnghia added the non-breaking Non-breaking change label Oct 30, 2024
@ttnghia
Copy link
Contributor Author

ttnghia commented Oct 31, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9657c9a into rapidsai:branch-24.12 Oct 31, 2024
86 checks passed
@ttnghia ttnghia deleted the fix_schema branch October 31, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttnghia @revans2