Move strings to date/time types benchmarks to nvbench #17229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
davidwendt
added
3 - Ready for Review
vuule
approved these changes
Nov 6, 2024
|
/merge |
karthikeyann
reviewed
Nov 7, 2024
Comment on lines
+27
to
+31
| NVBENCH_DECLARE_TYPE_STRINGS(cudf::duration_D, "cudf::duration_D", "cudf::duration_D"); | ||
| NVBENCH_DECLARE_TYPE_STRINGS(cudf::duration_s, "cudf::duration_s", "cudf::duration_s"); | ||
| NVBENCH_DECLARE_TYPE_STRINGS(cudf::duration_ms, "cudf::duration_ms", "cudf::duration_ms"); | ||
| NVBENCH_DECLARE_TYPE_STRINGS(cudf::duration_us, "cudf::duration_us", "cudf::duration_us"); | ||
| NVBENCH_DECLARE_TYPE_STRINGS(cudf::duration_ns, "cudf::duration_ns", "cudf::duration_ns"); |
There was a problem hiding this comment.
Could we move this to a common header?
And extend for other dtypes too.
There was a problem hiding this comment.
I've since seen other usages that I feel would require a separate PR to resolve.
Example: https://github.com/rapidsai/cudf/pull/17194/files#diff-2fa34b25a2e1b46e1e15f633b539e9b930a7728b9159e5ec810dd9d0e17bc50aR159-R219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the
cpp/benchmarks/string/convert_datetime.cppandcpp/benchmarks/string/convert_duration.cppbenchmark implementations from google-bench to nvbench.Checklist