Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude nanoarrow and flatbuffers from installation #17308

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 13, 2024

Description

This change helps shrink RAPIDS wheels. It should not affect Spark builds since those use the build directory of cudf and statically link in those components to its final binary.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 13, 2024
@vyasr vyasr self-assigned this Nov 13, 2024
@vyasr vyasr requested a review from a team as a code owner November 13, 2024 02:56
@vyasr
Copy link
Contributor Author

vyasr commented Nov 13, 2024

CC @jameslamb

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Nov 13, 2024
@vyasr
Copy link
Contributor Author

vyasr commented Nov 13, 2024

For the record, I spot-checked the wheels, one each for libcudf/pylibcudf/cudf:

(main) dt08% unzip -l cudf_cu11-24.12.0a344-cp310-cp310-manylinux_2_24_aarch64.manylinux_2_28_aarch64.whl | grep "flatbuffers"
(main) dt08% unzip -l cudf_cu11-24.12.0a344-cp310-cp310-manylinux_2_24_aarch64.manylinux_2_28_aarch64.whl | grep "nanoarrow"  
(main) dt08% unzip -l pylibcudf_cu12-24.12.0a344-cp311-cp311-manylinux_2_24_aarch64.manylinux_2_28_aarch64.whl| grep "flatbuffers"
(main) dt08% unzip -l pylibcudf_cu12-24.12.0a344-cp311-cp311-manylinux_2_24_aarch64.manylinux_2_28_aarch64.whl| grep "nanoarrow"  
(main) dt08% unzip -l libcudf_cu12-24.12.0a344-py3-none-manylinux_2_28_x86_64.whl | grep "flatbuffer"
(main) dt08% unzip -l libcudf_cu12-24.12.0a344-py3-none-manylinux_2_28_x86_64.whl | grep "nanoarrow" 

@vyasr
Copy link
Contributor Author

vyasr commented Nov 13, 2024

/merge

@jameslamb
Copy link
Member

Oh awesome, glad this was really all it took. Thank you!

@rapids-bot rapids-bot bot merged commit 918266a into rapidsai:branch-24.12 Nov 13, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants