Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rapidsai/pre-commit-hooks #6048

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Update rapidsai/pre-commit-hooks #6048

merged 2 commits into from
Aug 29, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

This PR updates rapidsai/pre-commit-hooks to the version 0.4.0.

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner August 27, 2024 15:39
@KyleFromNVIDIA KyleFromNVIDIA added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Aug 27, 2024
@jakirkham
Copy link
Member

We are seeing the same CI failures elsewhere: #6047

So those seem unrelated

@jakirkham
Copy link
Member

We just fixed the bulk of these issues with PR: #6031

There are some remaining tests that are skipped and being worked on separately: #6050

In any event, this PR should be unblocked. Pulled in the latest upstream changes to get a fresh CI run with those needed fixes

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 2f11570 into rapidsai:branch-24.10 Aug 29, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@jakirkham jakirkham jakirkham approved these changes

@raydouglass raydouglass Awaiting requested review from raydouglass raydouglass is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyleFromNVIDIA @jakirkham @jameslamb