Adding Spherical Surface Processing Capability to Point-in-Polygon Queries #1212

ayasar70 · 2023-07-07T21:48:17Z

Description

This PR aims to solve point-in-polygon queries using three-dimensional cartesian coordinates on spherical surfaces. Users may prefer to use that approach for more accurate computations.
This PR "closes #1202 "

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.

…o branch-23.08

rapids-bot · 2023-07-07T21:48:22Z

Pull requests from external contributors require approval from a rapidsai organization member with write permissions or greater before CI can begin.

cpp/include/cuspatial/geometry/vec_3d.hpp

cpp/include/cuspatial/detail/algorithm/is_point_in_polygon.cuh

isVoid · 2023-07-11T06:41:20Z

cpp/include/cuspatial/detail/algorithm/is_point_in_polygon.cuh

+  auto p3left = is_left(p1, p2, p3);
+  auto p4left = is_left(p1, p2, p4);
+
+  auto alpha = dot(p1, p3);


This says that if any of the end point of the arcs isn't in the same hemisphere, the arcs cannot intersect? Sounds like a very strict test.

Please cite the origin of this algorithm if you can @ayasar70

It was an old paper, and I was not able to find it yet. If I cannot find it, I am going to work on the verification.

Co-authored-by: Michael Wang <isVoid@users.noreply.github.com>

cpp/include/cuspatial/detail/geometry/polygon_ref.cuh

isVoid

Thanks for making this contribution!

isVoid · 2023-07-28T06:37:18Z

cpp/tests/point_in_polygon/point_in_polygon_test.cu

+TYPED_TEST(PointInPolygonTest, OnePolygonOneRingSpherical)
+{
+  CUSPATIAL_RUN_TEST(this->run_spherical_test,
+                     {{-2503.357, -4660.203, 3551.245},


What CRS is this coordinate?

Those are projections that consider the world as a sphere.

Ah I see, I remember you said this is the (X, Y, Z) coordinate using the center of earth as (0, 0, 0). For this algorithm it shouldn't matter how you choose the orthonormal basis as long as all coordinates are consistent. It would be nice to mention this in the docstring.

harrism

Thanks for the contribution @ayasar70 ! This is my initial review. Various doc suggestions and a couple of algorithmic questions/suggestions.

cpp/include/cuspatial/detail/algorithm/is_point_in_polygon.cuh

cpp/include/cuspatial/geometry/vec_3d.hpp

cpp/include/cuspatial/detail/algorithm/is_point_in_polygon.cuh

Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>

…nch-23.08

Co-authored-by: Michael Wang <isVoid@users.noreply.github.com>

harrism · 2023-08-02T01:23:41Z

/ok to test

harrism · 2023-08-02T01:24:11Z

Just realized CI hasn't been running for this PR!

…he spherical surface

… hemisphere.

harrism · 2023-08-02T13:08:58Z

/ok to test

harrism

I had one remaining unanswered question (about points on the boundary of the polygon. Please answer it before merging.

I will go ahead and approve. Nice work, and thank you. I note that this PR is just the beginning of support for this feature -- spherical PiP is only implemented in the C++ header-only API. To be a full feature it needs implementation in the column-based API and exposure in the Python API.

…nch-23.08

ayasar70 · 2023-08-02T23:46:39Z

I had one remaining unanswered question (about points on the boundary of the polygon. Please answer it before merging.

I will go ahead and approve. Nice work, and thank you. I note that this PR is just the beginning of support for this feature -- spherical PiP is only implemented in the C++ header-only API. To be a full feature it needs implementation in the column-based API and exposure in the Python API.

Thanks! Sorry, I missed the question before. I have replied. Just talked with @isVoid, after this PR I am going to start working on column-based API and Python API.

isVoid · 2023-08-03T00:40:20Z

/ok to test

isVoid · 2023-08-03T02:32:25Z

/merge

Abdurrahman Yasar and others added 7 commits June 26, 2023 18:10

adding spherical point-in-polygon kernel

c495f34

adding spherifal pip test and fixing vector issues

f0c6aaa

Merge branch 'rapidsai:branch-23.08' into branch-23.08

0a7c4f4

lint check

4758f80

Sync merge branch 'branch-23.08' of github.com:ayasar70/cuspatial int…

35dd52c

…o branch-23.08

Merge branch 'rapidsai:branch-23.08' into branch-23.08

0fe74be

minor: updating commit

454a421

github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Jul 7, 2023

isVoid added feature request New feature or request non-breaking Non-breaking change labels Jul 11, 2023

isVoid reviewed Jul 11, 2023

View reviewed changes

ayasar70 and others added 5 commits July 24, 2023 10:42

Merge branch 'rapidsai:branch-23.08' into branch-23.08

879eee4

Update cpp/include/cuspatial/geometry/vec_3d.hpp

ebab6fe

Co-authored-by: Michael Wang <isVoid@users.noreply.github.com>

cleaning unused methods under vec_3d

d2182ac

Merge branch 'rapidsai:branch-23.08' into branch-23.08

2589345

fixing issues related to rings adding tests

da97435

ayasar70 marked this pull request as ready for review July 28, 2023 04:57

ayasar70 requested a review from a team as a code owner July 28, 2023 04:57

ayasar70 requested review from trxcllnt and isVoid July 28, 2023 04:57

isVoid reviewed Jul 28, 2023

View reviewed changes

cpp/include/cuspatial/detail/geometry/polygon_ref.cuh Show resolved Hide resolved

isVoid approved these changes Jul 28, 2023

View reviewed changes

harrism requested changes Jul 29, 2023

View reviewed changes

ayasar70 and others added 6 commits July 30, 2023 21:41

Update cpp/include/cuspatial/detail/algorithm/is_point_in_polygon.cuh

03ccf3d

Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>

Update cpp/include/cuspatial/detail/algorithm/is_point_in_polygon.cuh

796e11e

Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>

Update cpp/include/cuspatial/detail/algorithm/is_point_in_polygon.cuh

f8de44b

Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>

Update cpp/include/cuspatial/geometry/vec_3d.hpp

a67b548

Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>

Update cpp/include/cuspatial/detail/algorithm/is_point_in_polygon.cuh

05bccda

Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>

Merge branch 'rapidsai:branch-23.08' into branch-23.08

9ee5b66

Abdurrahman Yasar and others added 6 commits July 31, 2023 10:00

addresing a couple of reviews

6e40f3e

Update cpp/include/cuspatial/geometry/vec_3d.hpp

7eeca08

Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>

update comment on vec_3d caused by copying the vec_2d class

7a91bea

Merge branch 'rapidsai:branch-23.08' into branch-23.08

d3df234

Merge branch 'branch-23.08' of github.com:ayasar70/cuspatial into bra…

e3b139c

…nch-23.08

Update cpp/include/cuspatial/detail/geometry/polygon_ref.cuh

7eba466

Co-authored-by: Michael Wang <isVoid@users.noreply.github.com>

ayasar70 and others added 7 commits August 1, 2023 22:09

Merge branch 'rapidsai:branch-23.08' into branch-23.08

383a46d

adding comment about assumption that all vertices and points are on t…

c519c56

…he spherical surface

fixing strict dot product check that was ignoring points on the other…

1928b8f

… hemisphere.

minor fix and adding a new test

ec2107c

Update cpp/include/cuspatial/geometry/vec_3d.hpp

65c9da5

Update cpp/include/cuspatial/detail/algorithm/is_point_in_polygon.cuh

8ab4c9a

Merge branch 'branch-23.08' into branch-23.08

872738d

harrism approved these changes Aug 2, 2023

View reviewed changes

Abdurrahman Yasar added 2 commits August 2, 2023 08:14

style fix

ecdace2

Merge branch 'branch-23.08' of github.com:ayasar70/cuspatial into bra…

d368eee

…nch-23.08

isVoid added 2 commits August 3, 2023 08:54

Merge branch 'branch-23.08' into branch-23.08

57cbd04

style fix

7d3042b

rapids-bot bot merged commit 1b1de7c into rapidsai:branch-23.08 Aug 3, 2023
55 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Spherical Surface Processing Capability to Point-in-Polygon Queries #1212

Adding Spherical Surface Processing Capability to Point-in-Polygon Queries #1212

ayasar70 commented Jul 7, 2023 •

edited

Loading

rapids-bot bot commented Jul 7, 2023

isVoid Jul 11, 2023

harrism Aug 2, 2023

ayasar70 Aug 2, 2023

isVoid left a comment

isVoid Jul 28, 2023

ayasar70 Jul 31, 2023

isVoid Aug 2, 2023 •

edited

Loading

harrism left a comment

harrism commented Aug 2, 2023

harrism commented Aug 2, 2023

harrism commented Aug 2, 2023

harrism left a comment

ayasar70 commented Aug 2, 2023

isVoid commented Aug 3, 2023

isVoid commented Aug 3, 2023

Adding Spherical Surface Processing Capability to Point-in-Polygon Queries #1212

Adding Spherical Surface Processing Capability to Point-in-Polygon Queries #1212

Conversation

ayasar70 commented Jul 7, 2023 • edited Loading

Description

Checklist

rapids-bot bot commented Jul 7, 2023

isVoid Jul 11, 2023

Choose a reason for hiding this comment

harrism Aug 2, 2023

Choose a reason for hiding this comment

ayasar70 Aug 2, 2023

Choose a reason for hiding this comment

isVoid left a comment

Choose a reason for hiding this comment

isVoid Jul 28, 2023

Choose a reason for hiding this comment

ayasar70 Jul 31, 2023

Choose a reason for hiding this comment

isVoid Aug 2, 2023 • edited Loading

Choose a reason for hiding this comment

harrism left a comment

Choose a reason for hiding this comment

harrism commented Aug 2, 2023

harrism commented Aug 2, 2023

harrism commented Aug 2, 2023

harrism left a comment

Choose a reason for hiding this comment

ayasar70 commented Aug 2, 2023

isVoid commented Aug 3, 2023

isVoid commented Aug 3, 2023

ayasar70 commented Jul 7, 2023 •

edited

Loading

isVoid Aug 2, 2023 •

edited

Loading