always pass -DCMAKE_INSTALL_RPATH_USE_LINK_PATH=ON for python editabl…

…e installs (#243)
rapidsai · Mar 7, 2024 · e11414f · e11414f
1 parent 3fa8e49
commit e11414f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/features/src/rapids-build-utils/devcontainer-feature.json b/features/src/rapids-build-utils/devcontainer-feature.json
@@ -1,7 +1,7 @@
 {
   "name": "NVIDIA RAPIDS devcontainer build utilities",
   "id": "rapids-build-utils",
-  "version": "24.4.2",
+  "version": "24.4.3",
   "description": "A feature to install the RAPIDS devcontainer build utilities",
   "containerEnv": {
     "BASH_ENV": "/etc/bash.bash_env"

diff --git a/features/src/rapids-build-utils/opt/rapids-build-utils/bin/tmpl/python.install.tmpl.sh b/features/src/rapids-build-utils/opt/rapids-build-utils/bin/tmpl/python.install.tmpl.sh
@@ -68,13 +68,13 @@ install_${PY_LIB}_python() {
 
     if rapids-python-uses-scikit-build-core "${PY_SRC}"; then
         pip_args+=(-C "build-dir=$(rapids-maybe-clean-build-dir "${cmake_args[@]}" -- "${PY_SRC}")");
-    elif test -n "${editable:-}"; then
+    elif test ${#editable[@]} -gt 0; then
         export SETUPTOOLS_ENABLE_FEATURES=legacy-editable;
-        cmake_args+=("-DCMAKE_INSTALL_RPATH_USE_LINK_PATH=ON");
     fi
 
     # Put --editable at the end of pip_args
     if test ${#editable[@]} -gt 0; then
+        cmake_args+=("-DCMAKE_INSTALL_RPATH_USE_LINK_PATH=ON");
         local i;
         local n=1;
         test -n "${editable:-}" && n=2;