Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate command to build pylibcudf #375

Merged
merged 6 commits into from
Aug 16, 2024
Merged

Conversation

lithomas1
Copy link
Contributor

@lithomas1 lithomas1 commented Jul 30, 2024

This makes the build-pylibcudf-python command and makes build-cudf depend on it.

Potentially needs admin-merge when changes look good?
cc @vyasr

@lithomas1 lithomas1 marked this pull request as ready for review August 14, 2024 20:45
@lithomas1 lithomas1 requested a review from a team as a code owner August 14, 2024 20:45
@lithomas1 lithomas1 requested review from bdice and trxcllnt and removed request for a team August 14, 2024 20:45
@Matt711 Matt711 mentioned this pull request Aug 14, 2024
12 tasks
@lithomas1
Copy link
Contributor Author

@vyasr @jameslamb

Can I also get a review here since y'all are already reviewing the other PR?

Thanks.

@vyasr
Copy link
Contributor

vyasr commented Aug 16, 2024

Once CI is passing on rapidsai/cudf#16299 for every other job, we can admin merge this one, redeploy, and rerun the devcontainer tests on that PR.

@jameslamb jameslamb self-requested a review August 16, 2024 16:23
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with @vyasr 's comment about the order of merging for this.

@vyasr vyasr merged commit c341e63 into rapidsai:branch-24.10 Aug 16, 2024
22 of 26 checks passed
vyasr added a commit that referenced this pull request Aug 16, 2024
@lithomas1 lithomas1 deleted the pylibcudf branch August 16, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants