Specify use_cuda_wheels=false in matrix entry #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With packages depending on CUDA wheels by default, we want to disable that behavior in devcontainers. Add a use_cuda_wheels=false matrix entry.
jameslamb
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Perfect, thank you! I think this is totally safe to add unconditionally here, and it'll help avoid build failures as we start merging PRs like rapidsai/raft#2415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With packages depending on CUDA wheels by default, we want to disable that behavior in devcontainers. Add a
use_cuda_wheels=falsematrix entry.Contributes to rapidsai/build-planning#35