-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote IO: http support #464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
improvement
Improves an existing functionality
non-breaking
Introduces a non-breaking change
labels
Sep 18, 2024
wence-
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++, not python yet
wence-
reviewed
Sep 24, 2024
madsbk
force-pushed
the
remote-io
branch
2 times, most recently
from
September 30, 2024 08:47
701f603
to
b886419
Compare
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
KyleFromNVIDIA
requested changes
Oct 7, 2024
KyleFromNVIDIA
approved these changes
Oct 7, 2024
wence-
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing more from me, looks good.
/merge |
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Oct 9, 2024
…17026) the same issue as NVIDIA/spark-rapids-jni#2475 due to rapidsai/kvikio#464 Port the fix from NVIDIA/spark-rapids-jni#2476, verified locally Authors: - Peixin (https://github.com/pxLi) Approvers: - Nghia Truong (https://github.com/ttnghia) URL: #17026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support read directly from a http server like:
This PR is the first step to support S3 using libcurl instead of aws-s3-sdk, which has some pros and cons:
S3Context
in libcudf and cudf to handle shutdown correctly. This is not a problem in libcurl, see https://curl.se/libcurl/c/libcurl.html underGlobal constants
.AWS_ACCESS_KEY_ID
andAWS_SECRET_ACCESS_KEY
.