Tests now can be SERIAL and use FetchContent to get rapids-cmake #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To properly test `cpm` packages in rapids-cmake we need to fix
two major issues.
1. A way to have tests that depend on the same CPM package
not execute at the same time. This is required so we don't
double checkout a project
2. A way to checkout and build projects such as RMM that themselves
use rapids-cmake without issue.
Number rapidsai#1 is solved by the introduction of the `SERIAL` keyword
Number rapidsai#2 is solved for most tests by having the `project_template`
that `.cmake` tests use get `rapids-cmake` via FETCH_CONENT. This
will allow us to verify local rapids-cmake changes against existing
projects that use rapids-cmake
robertmaynard
added
feature request
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 18, 2021
Requires #48 and #51 Adds rapids_cpm_<PackageName> for common packages Fixes #32 The following packages are now are easier to user for RAPIDS projects as rapids-cmake offers a pre-configured setup for each project. - GTest - NVBench - RMM - SpdLog - Thrust On top of providing a consistent version of these packages to all RAPIDS projects, rapids-cmake now is able to deduce when these projects should also be installed. ```cmake rapids_cpm_gtest(BUILD_EXPORT_SET myproject) rapdis_cpm_rmm(BUILD_EXPORT_SET myproject INSTALL_EXPORT_SET myproject) ``` Given the above snippet when RMM is built as a subcomponent of `myproject` it will be installed as well. This is done since RMM is part of the INSTALL export set, and therefore must be available from an installed version of `myproject`. Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly test
cpmpackages in rapids-cmake we need to fixtwo major issues.
A way to have tests that depend on the same CPM package
not execute at the same time. This is required so we don't
double checkout a project
A way to checkout and build projects such as RMM that themselves
use rapids-cmake without issue.
Number #1 is solved by the introduction of the
SERIALkeywordNumber #2 is solved for most tests by having the
project_templatethat
.cmaketests use getrapids-cmakevia FETCH_CONENT. Thiswill allow us to verify local rapids-cmake changes against existing
projects that use rapids-cmake