Use separate class to retry HTTP client requests

Set minimum test coverage to 100 percent

.github/workflows/run-tests.yml

@@ -48,4 +48,4 @@ jobs:
         run: composer show -D
 
       - name: Execute tests
-        run: XDEBUG_MODE=coverage php ./vendor/bin/pest --ci --coverage --do-not-cache-result
+        run: XDEBUG_MODE=coverage php ./vendor/bin/pest --ci --coverage --min=100 --do-not-cache-result

src/Api/ControlDFactory.php

@@ -21,9 +21,7 @@ public function make(): ControlD
             ->acceptJson()
             ->baseUrl($this->config->get('controld.url'))
             ->withToken($this->config->get('controld.secret'))
-            ->retry(3, 250, function ($e) {
-                return $e instanceof ConnectionException || $e->getCode() >= 500;
-            });
+            ->retry(3, 250, new RetryCallback());
 
         foreach ($this->config->get('controld.middleware') ?? [] as $middleware) {
             $this->request->withMiddleware(app($middleware));

src/Api/RetryCallback.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rapkis\Controld\Api;
+
+use Illuminate\Http\Client\ConnectionException;
+use Throwable;
+
+class RetryCallback
+{
+    public function __invoke(Throwable $exception): bool
+    {
+        return $exception instanceof ConnectionException || $exception->getCode() >= 500;
+    }
+}

tests/Api/ControlDFactoryTest.php

@@ -1,9 +1,9 @@
 <?php
 
 use Illuminate\Config\Repository;
-use Illuminate\Http\Client\ConnectionException;
 use Illuminate\Http\Client\PendingRequest;
 use Rapkis\Controld\Api\ControlDFactory;
+use Rapkis\Controld\Api\RetryCallback;
 use Rapkis\Controld\Tests\Api\TestMiddleware;
 
 it('creates an api client', function () {
@@ -29,9 +29,9 @@
         ->with($this->createStub(TestMiddleware::class))
         ->willReturnSelf();
 
-    $request->expects($this->once())->method('retry')->with(3, 250, function ($e) {
-        return $e instanceof ConnectionException || $e->getCode() >= 500;
-    })->willReturnSelf();
+    $request->expects($this->once())->method('retry')
+        ->with(3, 250, new RetryCallback())
+        ->willReturnSelf();
 
     $factory->make();
 });

tests/Api/RetryCallbackTest.php

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+use Illuminate\Http\Client\ConnectionException;
+use Rapkis\Controld\Api\RetryCallback;
+
+it('will retry for exception', function (Throwable $exception, bool $willRetry) {
+    $retry = new RetryCallback();
+
+    expect($retry($exception))->toBe($willRetry);
+})->with([
+    [new Exception(), false],
+    [new Exception('', 500), true],
+    [new Exception('', 422), false],
+    [new ConnectionException(), true],
+]);