drm/v3d: CPU job submissions shouldn't affect V3D GPU clock #6611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@popcornmix @mairacanal can you review this, it is a downstream patch as the V3D clock frequency management as this is only enabled downstream. We started seeing this issue with 6.12. It solves some issues we have to make timestamp queries work using GPU jobs in V3D, so we can land Mesa v3d: Add support for timestamp, time elapsed, and timestamp disjoint queries |
txenoo
force-pushed
the
no-clock-changes-on-cpu-jobs
branch
from
3eee4cc to
38515ff
Compare
|
LGTM, feel free to add my: |
We can avoid calling the v3d_clock_up_put and v3d_clock_up_get when a job is submitted to a CPU queue. We don't need to change the V3D core frequency to run a CPU job as it is executed on the CPU. This way we avoid delaying timestamps CPU jobs by 4.5ms that is the time that it takes the firmware to increase the V3D core frequency. Fixes: fe6a858 ("drm/v3d: Correct clock settng calls to new APIs") Signed-off-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com> Reviewed-by: Maíra Canal <mcanal@igalia.com>
txenoo
force-pushed
the
no-clock-changes-on-cpu-jobs
branch
from
38515ff to
7b8288b
Compare
|
A quick test looks fine. v3d clock still goes up and down, 3d renders and framerate from aquarium looks reasonable. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can avoid calling the v3d_clock_up_put and v3d_clock_up_get when a job is submitted to a CPU queue. This way we avoid delaying timestamps CPU jobs by 4.5ms that is the time that it takes to increase the V3D frequency when the V3D subsystem changes its clock frequency.
Fixes: fe6a858 ("drm/v3d: Correct clock settng calls to new APIs")