feat(showcase): add table built-in widget showcase #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
94ff963
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://65f848d0.ratatui.pages.dev |
| Branch Preview URL: | https://feat-table-showcase.ratatui.pages.dev |
Valentin271
force-pushed
the
feat/table-showcase
branch
from
d24d0d7 to
909c74f
Compare
orhun
approved these changes
Jan 2, 2024
joshka
approved these changes
Jan 2, 2024
|
|
||
| pub fn render(frame: &mut Frame) { | ||
| let rows = [ | ||
| Row::new(["1".bold(), "John".into(), "john.doe@mail.org".dim()]), |
There was a problem hiding this comment.
Add two more rows to fill the space in the image.
|
|
||
| let table = Table::new( | ||
| rows, | ||
| [Constraint::Min(8), Constraint::Min(15), Constraint::Min(20)], |
There was a problem hiding this comment.
Because we know the exact size of the image that we're displaying here, these lengths can be exact.
Maybe make the ID column narrower.
To fill the space better you could make the user names lower case, and add a Name column.
Valentin271
force-pushed
the
feat/table-showcase
branch
from
909c74f to
94ff963
Compare
|
Pushed 94ff963 "temporarily" as I don't have much time right now. Feedback is appreciated, I think it's better but the mail could be replaced by something more interesting imo |
|
LGTM - merging and will propose some changes in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #249