feat(showcase): showcase paragraph widget #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2024 22:46
|
Hey thanks for this, what about showing a little bit more. I think centering this and having something bold/underlined/colored could be nice. |
|
@Valentin271 no problem and thanks for the feedback 🎉
Edit: I've added three lines in total. I can add a few more :) Let me know if the sample text should be more descriptive |
|
If I can bother you to just tweak the .tape to not have so much empty space that'd be perfect.
|
|
Done. Are you also happy for me to attempt to provide PR's for the other widgets that are missing a showcase? |
|
Of course no problem! Thank you for this! |
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #249
Followed the instructions in Widget Showcase Readme to add a simple example of the Paragraph widget.