-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(showcase): showcase sparkline widget #471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a couple of small issues with this:
- We use git-lfs to avoid bloating the repo with images, but I think you might have just uploaded the image directly (I'm not super familiar with how to fix this up - possibly @orhun / @kdheepak / @Valentin271 can help?)
- The sparkline file needs to be formatted with rustfmt to fix up the line lengths
I'm not sure why, but I was also unable to directly update this branch to fix these issues when I tried.
|
That's probably because the PR is from my fork and you don't have permissions there. |
And I think you have to run the following after installing
and then use git like normal to make commits. I've updated the website contributing section to explicitly state that: https://ratatui.rs/developer-guide/website/ It seems like you've figured this out though, because the test that @Valentin271 set up is passing! So this PR looks good to me. |
Thanks for fixing this up. I've merged the change. |
Indeed
|
I could have sworn that I checked that that was ticked on the UI earlier, which was what confused me about this. Heisenbugs... |
And I was convinced I've checked that when creating the PR :) Anyway. Have a nice week. |
Relates to #249.
Adding a showcase entry for Sparkline widget