Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update log-with-tracing.md with trace_dbg! example #529

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kdheepak
Copy link
Contributor

No description provided.

Copy link

Deploying ratatui with  Cloudflare Pages  Cloudflare Pages

Latest commit: c82448f
Status: ✅  Deploy successful!
Preview URL: https://30dd7905.ratatui.pages.dev
Branch Preview URL: https://kd-trace-dbg.ratatui.pages.dev

View logs

Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to be consistent with the tracing-macros crate where this is found and use dbg! instead of trace_dbg!

Minimal preference for consistency. If you disagree based on trace_dbg being a generally better name, I'm happy to accept this as is.

@joshka
Copy link
Member

joshka commented Apr 1, 2024

I asked about the tracing_macros crate in the tokio discord: https://discord.com/channels/500028886025895936/974721015999516672/1224430040423334049

@kdheepak
Copy link
Contributor Author

kdheepak commented Apr 2, 2024

Happy to rename it! I didn’t realize that I swapped the names. Perhaps because I use dbg! so much normally.

@joshka
Copy link
Member

joshka commented Apr 2, 2024

Happy to rename it! I didn’t realize that I swapped the names. Perhaps because I use dbg! so much normally.

Ha, I assumed you'd done so with intention :D

@kdheepak
Copy link
Contributor Author

kdheepak commented Apr 2, 2024

If I did intend to do it I promptly forgot about it too :)

@joshka joshka mentioned this pull request Jun 4, 2024
joshka added a commit that referenced this pull request Jun 4, 2024
Adds a new `Block::border_set` method that allows the user to specify
the symbols used for the border.

Added two new border types: `BorderType::QuadrantOutside` and
`BorderType::QuadrantInside`. These are used to draw borders using the
unicode quadrant characters (which look like half block "pixels").

QuadrantOutside:
```
▛▀▀▜
▌  ▐
▙▄▄▟
```

QuadrantInside:
```
▗▄▄▖
▐  ▌
▝▀▀▘
```
Fixes: ratatui/ratatui#528

BREAKING CHANGES:
- BorderType::to_line_set is renamed to to_border_set
- BorderType::line_symbols is renamed to border_symbols
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants