-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update log-with-tracing.md with trace_dbg!
example
#529
base: main
Are you sure you want to change the base?
Conversation
Deploying ratatui with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to be consistent with the tracing-macros crate where this is found and use dbg! instead of trace_dbg!
Minimal preference for consistency. If you disagree based on trace_dbg being a generally better name, I'm happy to accept this as is.
I asked about the tracing_macros crate in the tokio discord: https://discord.com/channels/500028886025895936/974721015999516672/1224430040423334049 |
Happy to rename it! I didn’t realize that I swapped the names. Perhaps because I use |
Ha, I assumed you'd done so with intention :D |
If I did intend to do it I promptly forgot about it too :) |
Adds a new `Block::border_set` method that allows the user to specify the symbols used for the border. Added two new border types: `BorderType::QuadrantOutside` and `BorderType::QuadrantInside`. These are used to draw borders using the unicode quadrant characters (which look like half block "pixels"). QuadrantOutside: ``` ▛▀▀▜ ▌ ▐ ▙▄▄▟ ``` QuadrantInside: ``` ▗▄▄▖ ▐ ▌ ▝▀▀▘ ``` Fixes: ratatui/ratatui#528 BREAKING CHANGES: - BorderType::to_line_set is renamed to to_border_set - BorderType::line_symbols is renamed to border_symbols
No description provided.