-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showcase vs Examples part of the website #798
base: main
Are you sure you want to change the base?
Conversation
Yes, for the scrollbar widget it would be nice to have a small example screenshot that looks good in context with the other examples, so yes please if you'd like to contribute something. Probably in the size available I'd show a few different examples of scrollbars in each orientation, with various customizations and colors to make them look good.
You're right that there's some overlap, but perhaps I could explain my thinking on this and it would help work out what to do:
So at a high level, it's teaching vs demo. Right now we're also moving around the examples quite a bit for the next Ratatui release (0.30.0). Details in ratatui/ratatui#1512 (TLDR - splitting things up into simple examples, demos / application style examples, and tools). This will end up being reflected in the example section of the website when we sync them. Ideally each example would also have some narrative text associated with it (maybe worth LLM generating that), but we haven't got to that yet. Given that context, I'd suggest that we should:
Any other ideas you'd suggest? Another approach might be to make each example page have a bunch of small screenshot + code examples to make it super easy to copy paste the code that solves your problem directly into your own code. |
Thanks for the informations I've updated the PR with
Note that only LineGauge doesn't have an example |
Ha - I didn't look at this carefully enough and thought I was responding to an issue rather than a PR. Apologies for the brainfart :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the scrollbar image update this would be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer something smaller and more fitting with the other images in the showcase for this rather than reusing this image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the img
Is it better ?
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sizing is better, but it still feels a bit janky due to the text. The formatted lines of text are mostly unnecessary and take away from the part that's meaningful to show.
What I envisage: maybe 6ish vertical scroll bars (top, bottom, full, colored, symbols changed, symbols omitted) to show how customizable this is, and then the same for horizontal bars. Add that to a small paragraph with both bars and some greyed out Lorem ipsum text. The paragraph should be on the left to take up about 1/3 the space, while the extra bars take up the rest of the space on the right.
Hi
Does the scrollbar still need help ?
What is blocking #249 ?
Also, on the website these two pages are very similar https://ratatui.rs/examples/widgets/ https://ratatui.rs/showcase/widgets/. Why not merging them (add links to doc.rs) ?