Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.6 Support for Symfony 7 #1053

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

V0.6 Support for Symfony 7 #1053

wants to merge 26 commits into from

Conversation

joem236
Copy link

@joem236 joem236 commented Feb 1, 2024

No description provided.

simPod and others added 25 commits May 21, 2020 21:41
It is no longer supported
Bump PHP7 version and PHPUnit
Use Throwable instead of Exception
# Conflicts:
#	composer.json
(cherry picked from commit 2a6d3ab)
IoServerTest fails with older versions
…m v1+

futureTick() is missing in older versions
@Ovski4
Copy link

Ovski4 commented Feb 18, 2024

Thanks a lot for opening this PR. I was able to use your fork as a composer vcs repository and update a symfony application to version 7 successfully thanks to you

@treeindark
Copy link

treeindark commented Feb 19, 2024

Hello, i use plesk, with no problem, but i planed to upgrade symfony to 7.0. With your PR install is ok, but now, no more connection my messagehandler is no more call, and client have
Error: socket hang up

It a difference from plesk ?

@treeindark
Copy link

treeindark commented Feb 19, 2024

From plesk : (work with sf 6.4)

$wsServer = new WsServer(new WebSocketHandler());
$app = new HttpServer($wsServer);
$server = IoServer::factory($app, 8080);
$wsServer->enableKeepAlive($server->loop, 60);      
$server->run();

And i try with doc provided :

$app = new \Ratchet\App('192.168.1.200', 8080, '0.0.0.0');
$app->route('/', new WebSocketHandler(), ['*']);
$app->run();

but my handler is never call ( with breakpoint) with this 2methods

WebSocketHandler is MessageHandler implements MessageComponentInterface

@treeindark
Copy link

WsServer.php
126: $conn->send(Message::toString($response));

replace
17:
use GuzzleHttp\Psr7 as gPsr;
by
use GuzzleHttp\Psr7\Message;

@ebootingdev

This comment was marked as off-topic.

@dvdknaap
Copy link

why is this one not merged yet ?

@@ -5,7 +5,8 @@
use Symfony\Component\Routing\Matcher\UrlMatcherInterface;
use Symfony\Component\Routing\Exception\MethodNotAllowedException;
use Symfony\Component\Routing\Exception\ResourceNotFoundException;
use GuzzleHttp\Psr7\Query;
Copy link

@Tofandel Tofandel Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This namespace removal causes fatal errors because Query::parse and Query::build have not been replaced, in fact it's not even used

@@ -5,7 +5,8 @@
use Symfony\Component\Routing\Matcher\UrlMatcherInterface;
use Symfony\Component\Routing\Exception\MethodNotAllowedException;
use Symfony\Component\Routing\Exception\ResourceNotFoundException;
use GuzzleHttp\Psr7\Query;
use GuzzleHttp\Psr7 as gPsr;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use GuzzleHttp\Psr7 as gPsr;
use GuzzleHttp\Psr7\Query;

@@ -14,7 +14,8 @@
use Ratchet\RFC6455\Handshake\ServerNegotiator;
use Ratchet\RFC6455\Handshake\RequestVerifier;
use React\EventLoop\LoopInterface;
use GuzzleHttp\Psr7\Message;
use GuzzleHttp\Psr7 as gPsr;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use GuzzleHttp\Psr7 as gPsr;
use GuzzleHttp\Psr7\Message;

Same here

Comment on lines +36 to +37
, "react/socket": "^1.0 || ^0.8 || ^0.7 || ^0.6 || ^0.5 || ^v1.15"
, "react/event-loop": ">=v1.5.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, "react/socket": "^1.0 || ^0.8 || ^0.7 || ^0.6 || ^0.5 || ^v1.15"
, "react/event-loop": ">=v1.5.0"
, "react/socket": "^1.0 || ^0.8 || ^0.7 || ^0.6 || ^0.5"
, "react/event-loop": ">=0.4"

*Those changes are unnecessary because the previous range already allows those newer versions

, "react/socket": "^1.0 || ^0.8 || ^0.7 || ^0.6 || ^0.5 || ^v1.15"
, "react/event-loop": ">=v1.5.0"
, "guzzlehttp/psr7": "^1.7|^2.0|^2.6"
, "symfony/http-foundation": "^2.6|^3.0|^4.0|^5.0|^6.0|^v7.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, "symfony/http-foundation": "^2.6|^3.0|^4.0|^5.0|^6.0|^v7.0"
, "symfony/http-foundation": "^2.6|^3.0|^4.0|^5.0|^6.0|^7.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants