bash script for extractor.lua and remove old links #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamagarwal92
commented
Mar 7, 2019
shubhamagarwal92
commented
- Updated README; removing old links
- Removing hard coded paths in extractor.lua
- Shell script
… lua 3. Shell script
ratishsp
reviewed
Mar 8, 2019
extractor.lua
Outdated
| cmd:option('-convens_paths1', 'conv1-ep10-94-73' , [[path to conv net files]]) | ||
| cmd:option('-convens_paths2', 'conv2-ep10-95-71' , [[path to conv net files]]) | ||
| cmd:option('-convens_paths3', 'conv3-ep10-94-71' , [[path to conv net files]]) | ||
| cmd:option('-lstmens_paths1', 'lstm1-ep5-92-76' , [[path to conv net files]]) |
There was a problem hiding this comment.
change the hint, it should read path to lstm files
ratishsp
reviewed
Mar 8, 2019
| @@ -552,7 +569,9 @@ end | |||
| function main() | |||
| torch.manualSeed(opt.seed) | |||
| cutorch.manualSeed(opt.seed) | |||
| cutorch.setDevice(opt.gpuid) | |||
| device_id = cutorch.getDevice() | |||
There was a problem hiding this comment.
I am unsure about this change. Setting gpuid from input through opt.gpuid seems better.
There was a problem hiding this comment.
Actually, I was having this error when I used opts gpuid
THCudaCheck FAIL file=/tmp/luarocks_cutorch-scm-1-2141/cutorch/init.c line=734 error=10 : invalid device ordinal
/home/sagarwal/torch/install/bin/luajit: /home/sagarwal/projects/d2t/d2t/data2text-1/extractor.lua:574: cuda runtime error (10) : invalid device ordinal at /tmp/luarocks_cutorch-scm-1-2141/cutorch/init.c:734
stack traceback:
[C]: in function 'setDevice'
/home/sagarwal/projects/d2t/d2t/data2text-1/extractor.lua:574: in function 'main'
/home/sagarwal/projects/d2t/d2t/data2text-1/extractor.lua:677: in main chunk
[C]: in function 'dofile'
...rwal/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:150: in main chunk
[C]: at 0x00406470
srun: error: gpu05: task 0: Exited with exit code 1
I referenced this issue here
Maybe, the best solution would be to have a try-except statement instead?
There was a problem hiding this comment.
A point to note is that -gpuid parameter is 1-indexed.
If you set it to value like 0, it will give similar error.
In a 4 gpu setup, values such as 1, 2, 3, 4 are valid.
I normally run with -gpuid 1 and it works
ratishsp
reviewed
Mar 8, 2019
| th $LUA_FILE \ | ||
| -datafile $OUTPUT_H5 \ | ||
| -preddata $MODEL_DIR/roto_stage2_$IDENTIFIER-beam5_gens.h5 \ | ||
| -savefile $MODEL_DIR/roto_stage2_$IDENTIFIER-beam5_gens.h5-tuples.txt \ |
There was a problem hiding this comment.
-savefile is not applicable for -just_eval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.