Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make yamllint happy #16

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Make yamllint happy #16

merged 2 commits into from
Nov 13, 2023

Conversation

bhundven
Copy link
Contributor

💌 Description

Add a .yamllint file to disable the line-length rule, and add the yaml document start to actions.yaml.

Any developer that uses editors with syntax checking (specifically with yamllint) happier.

🔗 Related issue

🏗️ Type of change

  • 📚 Examples / docs / tutorials
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🚨 Security fix
  • ⬆️ Dependencies update

✅ Checklist

@bhundven
Make yamllint happy
82cfd0b 
Add a .yamllint file to disable the line-length rule, and add the yaml
[document start](https://yamllint.readthedocs.io/en/stable/rules.html#module-yamllint.rules.document_start) to actions.yaml.

Any developer that uses editors with syntax checking (specifically with
yamllint) happier.

Signed-off-by: Bryan Hundven <bryanhundven@gmail.com>
@bhundven bhundven requested a review from a team as a code owner November 12, 2023 20:45
@DariuszPorowski DariuszPorowski self-assigned this Nov 13, 2023
@DariuszPorowski DariuszPorowski added the enhancement New feature or request label Nov 13, 2023
@DariuszPorowski DariuszPorowski merged commit f4f25e4 into raven-actions:main Nov 13, 2023
1 of 2 checks passed
@bhundven bhundven deleted the yamllint branch November 13, 2023 20:52
@DariuszPorowski
Copy link
Collaborator

@bhundven thank you for the contribution. I did minor adjustments (moved config file to linters inside .github https://github.com/raven-actions/actionlint/blob/main/.github/linters/.yamllint.yml) as preparation to replace linting mechanism by https://github.com/oxsecurity/megalinter

@bhundven
Copy link
Contributor Author

You should check out super linter: https://github.com/marketplace/actions/super-linter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DariuszPorowski DariuszPorowski DariuszPorowski approved these changes

Assignees

@DariuszPorowski DariuszPorowski

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhundven @DariuszPorowski