docs: setup unified GTM #46290
Merged
docs: setup unified GTM #46290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saihajpreet Singh <c-saihajpreet.singh@anyscale.com>
saihaj
force-pushed
the
saihaj/unify-tags
branch
from
fc69411
to
4c378f3
Compare
| @@ -288,7 +288,6 @@ def render_svg_logo(path): | |||
| "csat", | |||
| ], | |||
| "navigation_depth": 4, | |||
| "analytics": {"google_analytics_id": "UA-110413294-1"}, | |||
There was a problem hiding this comment.
n00b question, why we are removing google analytics here?
There was a problem hiding this comment.
that will be injected by Google Tag manager. It is to manage all tags in one place for all websites we manage. With Google tag manager we will also inject cookiebot which will make sure Google analytics only runs when user gives permissions (where needed for compliance reasons)
cristianjd
approved these changes
Jun 28, 2024
can-anyscale
requested changes
Jul 2, 2024
saihaj
added a commit
to saihaj/ray
that referenced
this pull request
Jul 19, 2024
saihaj
added a commit
to saihaj/ray
that referenced
this pull request
Jul 19, 2024
Signed-off-by: Saihajpreet Singh <c-saihajpreet.singh@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
A unified setup with Google Tag manager to manage scripts that are loaded and also respecting user cookie configuration.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.