Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Add PPO StatelessCarePole learning tests (+LSTM) to CI. #46324

Merged

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jun 28, 2024

Add PPO StatelessCarePole learning tests (+LSTM) to CI.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's hope tests pass now.

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 changed the title [RLlib] De-flake APPO muti-agent CartPole learning tests. [RLlib] Add PPO StatelessCarePole learning tests (+LSTM) to CI. Aug 17, 2024
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) August 19, 2024 12:27
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 19, 2024
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@github-actions github-actions bot disabled auto-merge August 19, 2024 14:26
@sven1977 sven1977 enabled auto-merge (squash) August 19, 2024 14:27
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@github-actions github-actions bot disabled auto-merge August 19, 2024 18:59
@sven1977 sven1977 enabled auto-merge (squash) August 19, 2024 19:08
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@github-actions github-actions bot disabled auto-merge August 20, 2024 07:11
@sven1977 sven1977 enabled auto-merge (squash) August 20, 2024 09:19
@sven1977 sven1977 disabled auto-merge August 20, 2024 11:20
@sven1977 sven1977 enabled auto-merge (squash) August 20, 2024 12:14
@sven1977 sven1977 merged commit 0a3f286 into ray-project:master Aug 20, 2024
7 checks passed
@sven1977 sven1977 deleted the fix_appo_multi_agent_cartpole_tests branch August 20, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants