Add session name to api/version to easily identify cluster session #46332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Guo <aguo@anyscale.com>
Signed-off-by: Alan Guo <aguo@anyscale.com>
alanwguo
commented
Jun 28, 2024
| @@ -296,4 +298,4 @@ async def run(self, server): | |||
| def is_minimal_module(): | |||
| return False | |||
|
|
|||
| return ServeRestApiImpl(dashboard_module_superclass) | |||
There was a problem hiding this comment.
@shrekris-anyscale , can you review this change? This seems to be the incorrect behavior before. This function is supposed to return a class not an instance of the class.
There was a problem hiding this comment.
Yes, I think you're right. I'm not sure how we didn't catch this before, and how it didn't error before though.
woshiyyya
reviewed
Jun 28, 2024
woshiyyya
approved these changes
Jul 2, 2024
shrekris-anyscale
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Let's callers easily identify which "session" of the cluster is currently running.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.