Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Log ray version and ray commit during gcs start #46341

Merged
merged 4 commits into from
Jul 1, 2024
Merged

[Core] Log ray version and ray commit during gcs start #46341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59a87c1
Log ray version and ray commit during gcs start
jjyao Jun 29, 2024
99f3029
up
jjyao Jun 29, 2024
539c8b4
up
jjyao Jun 30, 2024
2e847b2
up
jjyao Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/ray/_private/services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1472,6 +1472,7 @@ def start_gcs_server(
f"--metrics-agent-port={metrics_agent_port}",
f"--node-ip-address={node_ip_address}",
f"--session-name={session_name}",
f"--ray-commit={ray.__commit__}",
]
if redis_address:
redis_ip_address, redis_port, enable_redis_ssl = get_address(redis_address)
Expand Down
7 changes: 7 additions & 0 deletions src/ray/gcs/gcs_server/gcs_server_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ DEFINE_string(node_ip_address, "", "The ip address of the node.");
DEFINE_string(session_name,
"",
"session_name: The session name (ClusterID) of the cluster.");
DEFINE_string(ray_commit, "", "The commit hash of Ray.");

int main(int argc, char *argv[]) {
InitShutdownRAII ray_log_shutdown_raii(ray::RayLog::StartRayLog,
Expand All @@ -47,6 +48,12 @@ int main(int argc, char *argv[]) {
ray::RayLog::InstallTerminateHandler();

gflags::ParseCommandLineFlags(&argc, &argv, true);

RAY_LOG(INFO)
.WithField("ray_version", kRayVersion)
.WithField("ray_commit", FLAGS_ray_commit)
<< "Ray cluster metadata";

const std::string redis_address = FLAGS_redis_address;
const int redis_port = static_cast<int>(FLAGS_redis_port);
const std::string log_dir = FLAGS_log_dir;
Expand Down
Loading