Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Retryable grpc client #47981

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Oct 10, 2024

Why are these changes needed?

Currently gcs_rpc_client has retries for gcs rpc calls and this PR moves the retry functionality to RetryableGrpcClient so that it can be used by non-gcs rpc client (e.g. core worker client).

Also enable retry for ReportGeneratorItemReturns rpc since it's idempotent.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Oct 11, 2024
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
src/ray/rpc/retryable_grpc_client.h Outdated Show resolved Hide resolved
src/ray/rpc/retryable_grpc_client.h Outdated Show resolved Hide resolved
src/ray/rpc/retryable_grpc_client.h Outdated Show resolved Hide resolved
src/ray/rpc/retryable_grpc_client.h Outdated Show resolved Hide resolved
src/ray/rpc/worker/core_worker_client.h Outdated Show resolved Hide resolved
src/ray/rpc/worker/core_worker_client.h Outdated Show resolved Hide resolved
src/ray/rpc/worker/core_worker_client.h Outdated Show resolved Hide resolved
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao marked this pull request as ready for review October 19, 2024 04:26
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao requested a review from rynewang October 19, 2024 04:37
@jjyao jjyao assigned jjyao and rynewang and unassigned rkooo567, rynewang and jjyao Oct 28, 2024
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao requested a review from a team as a code owner November 7, 2024 06:32
Copy link
Contributor

@dentiny dentiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First iteration on grpc retry client...

src/ray/rpc/retryable_grpc_client.h Outdated Show resolved Hide resolved
src/ray/rpc/retryable_grpc_client.h Outdated Show resolved Hide resolved
src/ray/rpc/retryable_grpc_client.h Outdated Show resolved Hide resolved
src/ray/rpc/retryable_grpc_client.h Outdated Show resolved Hide resolved
src/ray/rpc/retryable_grpc_client.h Outdated Show resolved Hide resolved
src/ray/rpc/retryable_grpc_client.h Outdated Show resolved Hide resolved
src/ray/rpc/retryable_grpc_client.h Show resolved Hide resolved
src/ray/rpc/retryable_grpc_client.h Outdated Show resolved Hide resolved
src/ray/rpc/retryable_grpc_client.h Show resolved Hide resolved
src/ray/rpc/retryable_grpc_client.h Outdated Show resolved Hide resolved
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants