Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required_resources to TrainWorkerInfo #49343

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alanwguo
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Alan Guo <aguo@anyscale.com>
Copy link
Contributor

@hongpeng-guo hongpeng-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a brief PR description. Is this for showing the required resources on each WorkerActor in its corresponding the dashboard row?

@alanwguo
Copy link
Contributor Author

Please add a brief PR description. Is this for showing the required resources on each WorkerActor in its corresponding the dashboard row?

hold off on reviewing for now. Just creating a PR to generate a wheel and do some manual testing

Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo
Copy link
Contributor Author

Looks like one of the issues is that the train run doesn't exist in the state actor until after it gets scheduled.

I need to know these required resources before so if there are issues scheduling the placement group, we can identify the autoscaler logs relevant to those scheduling issues.

Something we should capture with properly with the schema for TrainV2.

@matthewdeng @justinvyu @hongpeng-guo

Signed-off-by: Alan Guo <aguo@anyscale.com>
Signed-off-by: Alan Guo <aguo@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants